lkml.org 
[lkml]   [2015]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 7 Nov 2015 16:30:34 +0100

    The of_node_put() function tests whether its argument is NULL
    and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
    index 85b3326..9066d7a 100644
    --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
    +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
    @@ -2970,8 +2970,7 @@ err_out_unregister_netdev:
    err_out_clk_dis_aper:
    clk_disable_unprepare(lp->apb_pclk);
    err_out_free_netdev:
    - if (lp->phy_node)
    - of_node_put(lp->phy_node);
    + of_node_put(lp->phy_node);
    free_netdev(ndev);
    platform_set_drvdata(pdev, NULL);
    return ret;
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-07 17:01    [W:3.727 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site