Messages in this thread | | | Date | Fri, 6 Nov 2015 17:12:29 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [lustre-devel] [PATCH 07/10] staging: lustre: Handle nodemask on UMP machines |
| |
On Fri, Nov 06, 2015 at 10:18:17PM +0000, Simmons, James A. wrote: > >All warnings (new ones prefixed by >>): > > > > In file included from include/linux/bitops.h:36:0, > > from drivers/staging/lustre/lustre/libcfs/../../include/linux/libcfs/linux/libcfs.h:44, > > from drivers/staging/lustre/lustre/libcfs/../../include/linux/libcfs/libcfs.h:40, > > from drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c:38: > > drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c: In function 'cfs_cpt_table_alloc': > >>> arch/m68k/include/asm/bitops.h:64:5: warning: passing argument 2 of 'bset_mem_set_bit' from incompatible pointer type > > bset_mem_set_bit(nr, vaddr) : \ > > ^ > >>> drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c:61:3: note: in expansion of macro 'set_bit' > > set_bit(0, &cptab->ctb_nodemask); > > Yep and additional patch exist to fix this. Should I just push the fix for this or drop this patch and create > a new patch that is combo of both fixes. > > BTW Greg this new batch of patches are order independent. Sorry for not pointing that out. The rest of the > patch appear to be okay.
Ok, I'll drop this one, and apply the rest, please resend this after you have fixed it up.
thanks,
greg k-h
| |