lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1] mm: hwpoison: adjust for new thp refcounting
Date
On Fri, Nov 06, 2015 at 01:31:49AM -0500, Sasha Levin wrote:
> On 11/06/2015 01:11 AM, Naoya Horiguchi wrote:
> > In the new refcounting, we no longer use tail->_mapcount to keep tail's
> > refcount, and thereby we can simplify get_hwpoison_page() and remove
> > put_hwpoison_page() (by replacing with put_page()).
>
> This is confusing for the reader (and some static analysis tools): this adds
> put_page()s without corresponding get_page()s.
>
> Could we instead macro put_hwpoison_page() as put_page() for the sake of readability?

OK, I'll do this.

Thanks,
Naoya Horiguchi

\
 
 \ /
  Last update: 2015-11-06 08:21    [W:0.125 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site