lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] bq2415x_charger: Delete unnecessary checks before the function call "of_node_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 6 Nov 2015 16:48:46 +0100

    The of_node_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/power/bq2415x_charger.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c
    index 4afd768..27e8953 100644
    --- a/drivers/power/bq2415x_charger.c
    +++ b/drivers/power/bq2415x_charger.c
    @@ -1704,7 +1704,7 @@ error_4:
    error_3:
    bq2415x_power_supply_exit(bq);
    error_2:
    - if (bq && bq->notify_node)
    + if (bq)
    of_node_put(bq->notify_node);
    kfree(name);
    error_1:
    @@ -1724,9 +1724,7 @@ static int bq2415x_remove(struct i2c_client *client)
    if (bq->nb.notifier_call)
    power_supply_unreg_notifier(&bq->nb);

    - if (bq->notify_node)
    - of_node_put(bq->notify_node);
    -
    + of_node_put(bq->notify_node);
    bq2415x_sysfs_exit(bq);
    bq2415x_power_supply_exit(bq);

    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-06 17:21    [W:4.018 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site