lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] GPU-DRM-ps8622: Delete an unnecessary check before backlight_device_unregister()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 6 Nov 2015 14:38:34 +0100

    The backlight_device_unregister() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/bridge/parade-ps8622.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
    index be881e9..046fba0 100644
    --- a/drivers/gpu/drm/bridge/parade-ps8622.c
    +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
    @@ -646,9 +646,7 @@ static int ps8622_remove(struct i2c_client *client)
    {
    struct ps8622_bridge *ps8622 = i2c_get_clientdata(client);

    - if (ps8622->bl)
    - backlight_device_unregister(ps8622->bl);
    -
    + backlight_device_unregister(ps8622->bl);
    drm_bridge_remove(&ps8622->bridge);

    return 0;
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-06 15:01    [W:4.139 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site