lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 6 Nov 2015 10:36:49 +0100

    The of_node_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/misc/sram.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
    index 736dae7..34287f7 100644
    --- a/drivers/misc/sram.c
    +++ b/drivers/misc/sram.c
    @@ -326,9 +326,7 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
    }

    err_chunks:
    - if (child)
    - of_node_put(child);
    -
    + of_node_put(child);
    kfree(rblocks);

    return ret;
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-06 11:01    [W:5.031 / U:1.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site