lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] fjes: Delete an unnecessary check before the function call "vfree"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 6 Nov 2015 09:30:29 +0100

    The vfree() function performs also input parameter validation.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/fjes/fjes_hw.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/net/fjes/fjes_hw.c b/drivers/net/fjes/fjes_hw.c
    index 2d3848c..bb8b530 100644
    --- a/drivers/net/fjes/fjes_hw.c
    +++ b/drivers/net/fjes/fjes_hw.c
    @@ -143,9 +143,7 @@ static int fjes_hw_alloc_epbuf(struct epbuf_handler *epbh)

    static void fjes_hw_free_epbuf(struct epbuf_handler *epbh)
    {
    - if (epbh->buffer)
    - vfree(epbh->buffer);
    -
    + vfree(epbh->buffer);
    epbh->buffer = NULL;
    epbh->size = 0;

    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-06 10:01    [W:4.055 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site