Messages in this thread | | | Subject | Re: [PATCH v2] pwm-backlight: fix the panel power sequence | From | YH Huang <> | Date | Fri, 6 Nov 2015 16:31:30 +0800 |
| |
On Thu, 2015-11-05 at 10:40 +0100, Philipp Zabel wrote: > > > > Based on this, could we disable it initially and update in the > > backlight_update_status function? > > > > Like this, > > > > if (pb->enable_gpio) { > > if (phandle && > > gpiod_get_direction(pb->enable_gpio) == GPIOF_DIR_OUT && > > gpiod_get_value(pb->enable_gpio) == 1) > > gpiod_direction_output(pb->enable_gpio, 1); > > The gpiod_direction_output call is a no-op, since the direction is > already output and the value is already 1. > Also, I propose to set initial blanking to FB_BLANK_POWERDOWN in this > case, and wait for the panel driver to enable the backlight at the > appropriate time.
Thanks your kindly reply. Your patch looks good to me.
Regards, YH Huang
| |