lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging: most: Delete an unnecessary check before the function call "module_put"
    Relying on hidden sanity checks makes the code harder to read.  A human
    being cannot remember which functions have sanity checks and which do
    not. These sorts of patches are easy to generate automatically but they
    make the code worse. There are so many *better* things to do instead of
    focusing on making the code bad.

    Please stop sending these patches for drivers/staging. You are welcome
    to send them for other subsystems which I don't care about.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2015-11-05 15:01    [W:4.019 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site