lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] staging: most: Delete an unnecessary check before the function call "module_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Nov 2015 14:34:43 +0100

    The module_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/staging/most/mostcore/core.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
    index 19852ca..ed1ed25 100644
    --- a/drivers/staging/most/mostcore/core.c
    +++ b/drivers/staging/most/mostcore/core.c
    @@ -1587,8 +1587,7 @@ out:
    return 0;

    error:
    - if (iface->mod)
    - module_put(iface->mod);
    + module_put(iface->mod);
    modref--;
    mutex_unlock(&c->start_mutex);
    return ret;
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-05 15:01    [W:4.023 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site