Messages in this thread | | | Date | Wed, 4 Nov 2015 10:40:21 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [PATCH] livepatch: Cleanup page permission changes |
| |
On Tue, 3 Nov 2015, Josh Poimboeuf wrote:
> It's probably a good idea to keep the patches bisectable, so I made this > a separate patch which applies on top of the first one. > > (Note that it completely removes all the code from the first patch, so > there's no need for a v2 of the first patch which would have had > Miroslav's suggested style changes.)
I'd go along with Jiri and fold this patch to the first one.
> ---8<--- > > Subject: [PATCH] livepatch: Cleanup page permission changes > > Calling set_memory_rw() and set_memory_ro() for every iteration of the > loop in klp_write_object_relocations() is messy and inefficient. Change > all the RO pages to RW before the loop and convert them back to RO after > the loop. > > Suggested-by: Miroslav Benes <mbenes@suse.cz> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Great, I like the change.
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Cheers, Miroslav
| |