lkml.org 
[lkml]   [2015]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: sun4i: Implement MIC1 capture
On Mon, Nov 30, 2015 at 04:37:47PM +0100, Maxime Ripard wrote:

A couple of minor issues below but I'll apply this - please send
followup patches.

> +static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
> +{
> + /*
> + * FIXME: according to the BSP, we might need to drive a PA
> + * GPIO high here on some boards
> + */

That's not something this driver needs to worry about, that's something
the machine driver will do - the whole purpose is to glue all the
different components on the board together.

> + if (clk_set_rate(scodec->clk_module, clk_freq))
> + return -EINVAL;

It'd be better to pass back the error code from clk_set_rate().
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-11-30 17:41    [W:0.077 / U:1.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site