Messages in this thread | | | Date | Mon, 30 Nov 2015 10:17:32 -0200 | Subject | Re: [PATCH 2/3] net: fec: convert to using gpiod framework | From | Fabio Estevam <> |
| |
On Mon, Nov 30, 2015 at 9:32 AM, Lothar Waßmann <LW@karo-electronics.de> wrote:
> - gpio_set_value_cansleep(phy_reset, 1); > + gpiod_set_value_cansleep(phy_reset, 1);
This will break some existing DTBs.
Currently the fec driver does not care whether 'phy-reset-gpios' is active low or active high. (Yes, it was a mistake to assume in the driver that it is always active low.)
After this change the polarity will be taken into account and may break some dtb's.
I suggest you to send a single patch with the minimum changes to fix the regression caused by 8fff755e9f8d ("net: fec: Ensure clocks are enabled while using mdio bus").
| |