lkml.org 
[lkml]   [2015]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] dma: add Qualcomm Technologies HIDMA channel driver
Date
On Tuesday 03 November 2015 16:07:34 Sinan Kaya wrote:
> On 11/3/2015 5:43 AM, Arnd Bergmann wrote:
> > Ok, got it.
> >
> > Best add an explanation like the above in the interrupt handler,
> > to prevent this from accidentally getting 'cleaned up' to use
> > readl(), or copied into a driver that uses PCI ordering rules
> > where it is actually wrong.
> >
>
> I'm adding this disclaimer into the ISR routine.
>
> /*
> * Fine tuned for this HW...
> *
> * This ISR has been designed for this particular hardware. Relaxed read
> * and write accessors are used for performance reasons due to interrupt
> * delivery guarantees. Do not copy this code blindly and expect
> * that to work.
> */
>
>

Sounds good.

Arnd


\
 
 \ /
  Last update: 2015-11-03 22:41    [W:0.120 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site