Messages in this thread | | | Date | Tue, 3 Nov 2015 21:14:55 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware |
| |
On Mon, Nov 02, 2015 at 07:17:28AM +0000, Kweh, Hock Leong wrote: > This is not a return value to indicate what is going now. It is a flag > used in "cap_info->index" which positive value has a meaning of index > number. I am using the negative value for the flag which similar to > the implementation of pointer & error pointer (ERR_PTR).
Ok, but that doesn't make any sense: you're assigning UPLOAD_DONE to cap_info->index only once in efi_capsule_submit_update() and you're not testing it anywhere. Yeah, yeah, you're implicitly testing for it by doing the "< 0" check.
So simply assign -1 to ->index to mean *any* type of error occurred, remove the defines and you can always test for "< 0" to mean "did something fail".
You simply don't need two error values...
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |