Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused | Date | Tue, 03 Nov 2015 17:42:26 +0100 |
| |
On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote: > On Tue, 03 Nov 2015 16:05:51 +0100 > Arnd Bergmann <arnd@arndb.de> wrote: > > > The SoC variant of the ssb code is now optional like the other > > ones, which means we can build the framwork without any > > front-end, but that results in a warning: > > > > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function] > > > > This annotates the ssb_bus_register function as __maybe_unused to > > shut up the warning. A configuration like this will not work on > > any hardware of course, but we still want this to silently build > > without warnings if the configuration is allowed in the first > > place. > > > Is there a simple way to disallow this configuration?
I could not come up with a simple one. We could turn 'CONFIG_SSB' into a silent option and have it selected by each bus specific driver, but then we also have to change all the device drivers (usb and wireless I guess) to use 'depends on' rather than 'select'.
Arnd
| |