lkml.org 
[lkml]   [2015]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/21] drbd: use true/false for bool
    Date
    Fix 4 coccinelle warnings

    Signed-off-by: Fabian Frederick <fabf@skynet.be>
    ---
    drivers/block/drbd/drbd_receiver.c | 4 ++--
    drivers/block/drbd/drbd_worker.c | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
    index d4c807c..ad9b99b 100644
    --- a/drivers/block/drbd/drbd_receiver.c
    +++ b/drivers/block/drbd/drbd_receiver.c
    @@ -2065,13 +2065,13 @@ static inline int overlaps(sector_t s1, int l1, sector_t s2, int l2)
    static bool overlapping_resync_write(struct drbd_device *device, struct drbd_peer_request *peer_req)
    {
    struct drbd_peer_request *rs_req;
    - bool rv = 0;
    + bool rv = false;

    spin_lock_irq(&device->resource->req_lock);
    list_for_each_entry(rs_req, &device->sync_ee, w.list) {
    if (overlaps(peer_req->i.sector, peer_req->i.size,
    rs_req->i.sector, rs_req->i.size)) {
    - rv = 1;
    + rv = true;
    break;
    }
    }
    diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
    index e427ba0..17874bc 100644
    --- a/drivers/block/drbd/drbd_worker.c
    +++ b/drivers/block/drbd/drbd_worker.c
    @@ -1627,7 +1627,7 @@ static bool use_checksum_based_resync(struct drbd_connection *connection, struct
    rcu_read_unlock();
    return connection->agreed_pro_version >= 89 && /* supported? */
    connection->csums_tfm && /* configured? */
    - (csums_after_crash_only == 0 /* use for each resync? */
    + (csums_after_crash_only == false /* use for each resync? */
    || test_bit(CRASHED_PRIMARY, &device->flags)); /* or only after Primary crash? */
    }

    @@ -1762,7 +1762,7 @@ void drbd_start_resync(struct drbd_device *device, enum drbd_conns side)
    device->bm_resync_fo = 0;
    device->use_csums = use_checksum_based_resync(connection, device);
    } else {
    - device->use_csums = 0;
    + device->use_csums = false;
    }

    /* Since protocol 96, we must serialize drbd_gen_and_send_sync_uuid
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-11-27 22:41    [W:4.110 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site