Messages in this thread | | | From | Rob Herring <> | Date | Fri, 27 Nov 2015 14:14:03 -0600 | Subject | Re: [PATCH v2 1/1] platform: goldfish: pipe: add devicetree bindings |
| |
On Fri, Nov 27, 2015 at 12:17 PM, Greg Hackmann <ghackmann@google.com> wrote: > On 11/26/15 12:34 AM, Christoffer Dall wrote: >> >> On Wed, Nov 25, 2015 at 02:24:16PM -0600, Rob Herring wrote: >>> >>> >>> The binding may be trivial, but there's a bigger question of whether >>> this is the right long term direction. For example is upstream QEMU >>> going to take all the Android pipe stuff? Couldn't virtio be used here >>> as the transport? >>> >> >> But I wonder if that should really block this from being merged? The >> support may not be in QEMU but it's in the Android emulator and it would >> be a less broken implementation with these patches in the kernel than >> without, I think. >> >> -Christoffer >> > > To add to Christoffer's point, we added these bindings so we don't need to > rely on the goldfish virtual bus for probing anymore. > > Switching from the goldfish virtual bus to Device-Tree already eliminates > one big piece where the Android emulator has diverged from upstream qemu. > And on the kernel side, it means we don't need ARM and MIPS goldfish board > code to instantiate the bus.
Okay, fair enough. That's not evident from the patch.
Rob
| |