Messages in this thread | | | Date | Fri, 27 Nov 2015 21:06:03 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] hw_random: core, sleep interruptible in read |
| |
On Thu, Nov 26, 2015 at 08:56:29PM +0100, Jiri Slaby wrote: > > diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c > index a064237ff362..f003df162e09 100644 > --- a/drivers/char/hw_random/core.c > +++ b/drivers/char/hw_random/core.c > @@ -238,7 +238,10 @@ static ssize_t rng_dev_read(struct file *filp, char __user *buf, > goto out; > } > > - mutex_lock(&reading_mutex); > + if (mutex_lock_interruptible(&reading_mutex)) { > + err = -EINTR;
Shouldn't this be ERESTARTSYS?
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |