Messages in this thread | | | Date | Fri, 27 Nov 2015 13:02:03 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH V5 RESEND 2/3] iommu/hisilicon: Add hi6220-SoC smmu driver |
| |
On Fri, Nov 20, 2015 at 10:25:08AM +0800, Chen Feng wrote: > +config HI6220_IOMMU > + bool "Hi6220 IOMMU Support" > + depends on ARM64 > + select IOMMU_API > + select IOMMU_IOVA > + help > + Enable IOMMU Driver for hi6220 SoC. The IOMMU API and IOMMU IOVA > + is also selected.
The last sentence is of little help for the user. Better put the reasons in here when a user should select this option.
> + /*set axi id*/
Coding style nit: Please write these oneline comments with spaces, like this:
/* set axi id */
> +static int hi6220_smmu_attach_dev(struct iommu_domain *domain, > + struct device *dev) > +{ > + dev->archdata.iommu = &iova_allocator; > + > + return 0; > +} > + > +static void hi6220_smmu_detach_dev(struct iommu_domain *domain, > + struct device *dev) > +{ > + dev->archdata.iommu = NULL; > +}
This basically means that this driver only supports one domain, right? That is not compatible with the iommu-api requirements.
You need to create an iommu-group per smmu in your system and put all devices translated by this smmu in that group. And then you must change your code to allow attaching/detaching this iommu-group to different domains.
Joerg
| |