lkml.org 
[lkml]   [2015]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf tools: Always give options even it not compiled


On 2015/11/20 18:54, 平松雅巳 / HIRAMATU,MASAMI wrote:
>> From: Wang Nan [mailto:wangnan0@huawei.com]
>>
>> This patch keeps options of perf builtins same in all condition. If the
>> option is disabled because of compiling options, users should be
>> notified.
>>
>> This patch does it by introducing a series of new option macros, flags
>> and field in struct options. For those options disabled by compiling,
>> OPT_NOTBUILT_NOARG, OPT_NOTBUILT_OPTARG and OPT_NOTBUILT can be used
>> to record the help messages and the reason why not built them.
>>
>> Options in 'perf record' and 'perf probe' are fixed by those new macros.
> Hmm, OK, I agree the reason why this is useful. Could you reconsider
> the implementation, because just cloning the code is ugly and not
> maintainable?
>
> It will be better if we can replace OPT_BOOLEAN with;
>
> OPT_DEPENDS(HAVE_DWARF_SUPPORT, BOOLEAN, '\0', "no-inlines", &probe_conf.no_inlines, ...
>
> This may be done by following macros ;
>
> ----
> #define OPTMSG_HAVE_DWARF_SUPPORT "NO_DWARF"
> #ifdef HAVE_DWARF_SUPPORT
> #define OPTVAL_HAVE_DWARF_SUPPORT 1
> #else
> #define OPTVAL_HAVE_DWARF_SUPPORT 0
> #endif
>
> #define __OPT_DEPENDS(val, msg, opt, ...) \
> {.type = OPTION_NEXT_DEPENDS, .value = (void *)val, .data = msg, }, opt(__VA_ARGS__)
>
> #define _OPT_DEPENDS(val, msg, opt, ...) \
> __OPT_DEPENDS(val, msg, opt, __VA_ARGS__)
>
> #define OPT_DEPENDS(flag, opt, ...) \
> _OPT_DEPENDS(OPTVAL_ ## flag, OPTMSG_ ## flag, OPT_ ## opt, __VA_ARGS__)
> ----
>
> And if the parser find OPTION_NEXT_DEPENDS and .value != NULL, it skips next entry.
>

That would be good, but don't forget we have a options__order() which
reorder the options array. To archive our goal I think we must preprocess
the options array to 'merge' information in the OPTION_NEXT_DEPENDS into
the real option it decorates.

Thank you.

> Thank you,
>




\
 
 \ /
  Last update: 2015-11-26 09:21    [W:0.106 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site