Messages in this thread | | | Date | Thu, 26 Nov 2015 08:47:18 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH v2] USB: serial: cp210x: Add tx_empty() |
| |
On Thu, Nov 26, 2015 at 08:35:12AM +0100, Johan Hovold wrote: > On Wed, Nov 25, 2015 at 10:26:12PM +0200, Andy Shevchenko wrote: > > On Wed, Nov 25, 2015 at 12:28 AM, Konstantin Shkolnyy > > <konstantin.shkolnyy@gmail.com> wrote: > > > Added tx_empty callback needed for generic wait-until-sent support. > > > Without this function, when the port is closed usbserial can't know that > > > there are still data in the chip's transmit FIFO. The chip gets disabled > > > and untransmitted data lost. When the actual byte count is reported by > > > tx-empty the close can be delayed until all data are sent.
> > Btw, can be count left uninitialized? > > Yes, but that's not an issue. Clearly separating the success and errors > paths as I suggested above would make that more obvious however. > > I'll fix that up before applying.
Now applied, thanks.
Johan
| |