lkml.org 
[lkml]   [2015]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] USB: serial: cp210x: Add tx_empty()
On Thu, Nov 26, 2015 at 08:35:12AM +0100, Johan Hovold wrote:
> On Wed, Nov 25, 2015 at 10:26:12PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 25, 2015 at 12:28 AM, Konstantin Shkolnyy
> > <konstantin.shkolnyy@gmail.com> wrote:
> > > Added tx_empty callback needed for generic wait-until-sent support.
> > > Without this function, when the port is closed usbserial can't know that
> > > there are still data in the chip's transmit FIFO. The chip gets disabled
> > > and untransmitted data lost. When the actual byte count is reported by
> > > tx-empty the close can be delayed until all data are sent.

> > Btw, can be count left uninitialized?
>
> Yes, but that's not an issue. Clearly separating the success and errors
> paths as I suggested above would make that more obvious however.
>
> I'll fix that up before applying.

Now applied, thanks.

Johan


\
 
 \ /
  Last update: 2015-11-26 09:01    [W:0.067 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site