Messages in this thread | | | Subject | Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function | From | Joe Perches <> | Date | Thu, 26 Nov 2015 11:46:14 -0800 |
| |
On Thu, 2015-11-26 at 19:41 +0800, Ching Huang wrote: > split dma resource allocation and io register assignment from get_config to a new function arcmsr_alloc_io_queue.
trivia:
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c [] > +static bool arcmsr_alloc_io_queue(struct AdapterControlBlock *acb) > +{ [] > + dma_coherent = dma_alloc_coherent(&pdev->dev, acb->roundup_ccbsize, > + &dma_coherent_handle, GFP_KERNEL); > + if (!dma_coherent){ > + pr_notice("arcmsr%d: DMA allocation failed.\n", acb->host->host_no); > + return false; > + } > + memset(dma_coherent, 0, acb->roundup_ccbsize); >
There is a dma_zalloc_coherent
(and even more trivially)
Most all of your error messages don't use periods.
| |