Messages in this thread | | | Date | Thu, 26 Nov 2015 19:11:49 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/3] perf build: Use FEATURE-INCLUDE in bpf subproject |
| |
On Thu, Nov 26, 2015 at 01:31:30PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 26, 2015 at 02:54:03PM +0100, Jiri Olsa escreveu: > > Using FEATURE-INCLUDE in bpf subproject in case bpf is built > > via perf. Keep the current features detection for other cases. > > > > Cc: Wang Nan <wangnan0@huawei.com> > > Link: http://lkml.kernel.org/n/tip-utuczk899ckz6qtggqvhm7yu@git.kernel.org > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > Clashes with: > > d8ad6a15cc3a ("tools lib bpf: Don't do a feature check when cleaning") > > That has, at that point: > > +check_feat := 1 > +NON_CHECK_FEAT_TARGETS := clean TAGS tags cscope help > +ifdef MAKECMDGOALS > +ifeq ($(filter-out $(NON_CHECK_FEAT_TARGETS),$(MAKECMDGOALS)),) > + check_feat := 0 > +endif > +endif > + > +ifeq ($(check_feat),1) > include $(srctree)/tools/build/Makefile.feature > +endif
I see, please take that one, I'll rebase my changes over that
we still need more comments/feedback on that anyway ;-)
jirka
| |