Messages in this thread | | | Subject | Re: [PATCH] target: xen-scsiback: Return proper -Exx instead of -1. | From | Juergen Gross <> | Date | Thu, 26 Nov 2015 07:36:33 +0100 |
| |
On 25/11/15 20:24, Konrad Rzeszutek Wilk wrote: > We could return EINVAL but EBUSY (or EALREADY?)is more appropiate. > > CC: jgross@suse.com > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
While it doesn't really matter it's cleaner.
Reviewed-by: Juergen Gross <jgross@suse.com>
> --- > drivers/xen/xen-scsiback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c > index 43bcae8..286e3da 100644 > --- a/drivers/xen/xen-scsiback.c > +++ b/drivers/xen/xen-scsiback.c > @@ -800,7 +800,7 @@ static int scsiback_init_sring(struct vscsibk_info *info, grant_ref_t ring_ref, > int err; > > if (info->irq) > - return -1; > + return -EBUSY; > > err = xenbus_map_ring_valloc(info->dev, &ring_ref, 1, &area); > if (err) >
| |