lkml.org 
[lkml]   [2015]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ASoC: hdac_hdmi: convert num_nodes to int
On Thu, 26 Nov 2015 09:08:19 +0100,
Sudip Mukherjee wrote:
>
> All uses of num_nodes are considering it as a signed integer and that is
> very much clear when we try to save the error value in it and later try
> to compare it with less than 0.

No. The point is that the value checked *there* has to be int, not
the value used for the success case. Just have a temporary value,
e.g. int num_nodes, assign there, check it, then assign the value to
codec->num_nodes field. The num_nodes field itself is obviously an
unsigned.


Takashi


>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> include/sound/hdaudio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index e2b712c..c5fad14 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -71,7 +71,7 @@ struct hdac_device {
> unsigned int flags, unsigned int *res);
>
> /* widgets */
> - unsigned int num_nodes;
> + int num_nodes;
> hda_nid_t start_nid, end_nid;
>
> /* misc flags */
> --
> 1.9.1
>
>


\
 
 \ /
  Last update: 2015-11-26 09:41    [W:0.032 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site