lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: severe regression in alx ethernet driver
From
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Wed, 25 Nov 2015 23:47:08 +0100

> Jarod Wilson <jarod@redhat.com> :
> [...]
>> They do at least have a signed-off-by in the patches attached to the bug,
>> so I'm working on touching up the descriptions and formatting, regression
>> testing them on my laptop that has an alx-driven E2200 in it (which isn't
>> affected by this bug), and then I can ship them up for proper review.
>
> You can forget the last refill-me-harder patch and save a roundtrip.
> The driver should 1) prohibit holes in its receive ring, 2) allocate before
> pushing data up in the stack and 3) drop packets when it can't allocate a
> fresh buffer.

+1


\
 
 \ /
  Last update: 2015-11-26 05:41    [W:0.055 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site