lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] mm, oom: introduce oom reaper
    Hi Michal,

    I think whatever we end up doing to smoothen things for the "common
    case" (as much as OOM kills can be considered common), we need a plan
    to resolve the memory deadlock situations in a finite amount of time.

    Eventually we have to attempt killing another task. Or kill all of
    them to save the kernel.

    It just strikes me as odd to start with smoothening the common case,
    rather than making it functionally correct first.

    On Wed, Nov 25, 2015 at 04:56:58PM +0100, Michal Hocko wrote:
    > A kernel thread has been chosen because we need a reliable way of
    > invocation so workqueue context is not appropriate because all the
    > workers might be busy (e.g. allocating memory). Kswapd which sounds
    > like another good fit is not appropriate as well because it might get
    > blocked on locks during reclaim as well.

    Why not do it directly from the allocating context? I.e. when entering
    the OOM killer and finding a lingering TIF_MEMDIE from a previous kill
    just reap its memory directly then and there. It's not like the
    allocating task has anything else to do in the meantime...

    > @@ -1123,7 +1126,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
    > continue;
    > }
    > /* If details->check_mapping, we leave swap entries. */
    > - if (unlikely(details))
    > + if (unlikely(details || !details->check_swap_entries))
    > continue;

    &&


    \
     
     \ /
      Last update: 2015-11-25 21:41    [W:2.623 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site