Messages in this thread | | | From | Måns Rullgård <> | Subject | Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller | Date | Wed, 25 Nov 2015 12:12:42 +0000 |
| |
Mason <slash.tmp@free.fr> writes:
>> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >> + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > In my local branch, I wrote: > > #define IRQ_CTL_LO 0 > > status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); > status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > (I'm a sucker for symmetry)
Nothing wrong with a little symmetry, though in this case I think the extra macro only confuses matters.
-- Måns Rullgård mans@mansr.com
| |