Messages in this thread | | | Date | Wed, 25 Nov 2015 11:18:58 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new |
| |
On Wed, Nov 25, 2015 at 11:07:01AM +0000, Richard Fitzgerald wrote: > On Wed, 2015-11-25 at 11:49 +0100, Takashi Iwai wrote:
> > > + if (IS_ENABLED(CONFIG_SND_VERBOSE_PROCFS))
> > This should be #if. Otherwise the compile would fail (as already
> Builds ok for me, this will become if(false) if it's not enabled so the > compiler will strip it out - some maintainers prefer that to #if and I'm > used to being told to use this style instead of #if, so who knows what > today's coding style is :) The build bot failure was for a different > reason.
The compiler will still spot syntax errors and similar in an if (false) section. [unhandled content-type:application/pgp-signature] | |