lkml.org 
[lkml]   [2015]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: dsa: include gpio consumer header file
On Tue, Nov 24, 2015 at 12:34:49PM +0100, Arnd Bergmann wrote:
> After the introduction of the switch gpio reset API, I'm getting
> build errors in configurations that disable CONFIG_GPIOLIB:
>
> net/dsa/dsa.c:783:16: error: implicit declaration of function 'gpio_to_desc' [-Werror=implicit-function-declaration]
>
> The reason is that linux/gpio/consumer.h is not automatically
> included without gpiolib support. This adds an explicit #include
> statement to make it compile in all configurations. The reset
> functionality will not work without gpiolib, which is what you
> get when disabling the feature.
>
> As far as I can tell, gpiolib is supported on all architectures
> on which you can have DSA at the moment.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cc30c16344fc ("net: dsa: Add support for a switch reset gpio")

Hi Arnd

Thanks for this. I had something similar in my github overnight so
that 0-day would build test it.

Acked-by: Andrew Lunn <andrew@lunn.ch>

Andrew


\
 
 \ /
  Last update: 2015-11-24 15:41    [W:0.038 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site