Messages in this thread | | | Date | Tue, 24 Nov 2015 09:55:32 +0100 | From | Florian Westphal <> | Subject | Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb |
| |
K. Y. Srinivasan <kys@microsoft.com> wrote: > The rndis header is 116 bytes big and can be placed in the default > head room that will be available in the skb. Since the netvsc packet > is less than 48 bytes, we can use the skb control buffer > for the netvsc packet. With these changes we don't need to > ask for additional head room.
Minor nit: could you add a BUILD_BUG_ON test for this? Something like
BUILD_BUG_ON(sizeof(struct hv_netvsc_packet) > FIELD_SIZEOF(struct sk_buff, cb));
| |