lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module
From
Date
On 11/23/2015 10:57 AM, Arnd Bergmann wrote:
> On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote:
>> Separate out I2C functionality into a module. This fixes several small
>> issues and simplifies the driver initialization.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> That looks good to me overall, it should help with the randconfig
> warnings I've been seeing and makes the driver structured more logically.
>
> The one part I wonder about is whether the platform_driver portion
> should also be split out into a separate module in the same way.
>
> Arnd
>

I think it should, I'm just waiting until I can find some time to
bring up regmap for 1wire, then I can really clean things up and
move the platform stuff (which is really the 1wire interface) out
more cleanly, all I'll need to do then is just pass a regmap handle
to the core from the interface modules.

But that's all a project for another day :)


\
 
 \ /
  Last update: 2015-11-23 19:01    [W:1.317 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site