Messages in this thread | | | Subject | Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module | From | "Andrew F. Davis" <> | Date | Mon, 23 Nov 2015 11:09:50 -0600 |
| |
On 11/23/2015 10:57 AM, Arnd Bergmann wrote: > On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: >> Separate out I2C functionality into a module. This fixes several small >> issues and simplifies the driver initialization. >> >> Signed-off-by: Andrew F. Davis <afd@ti.com> > > That looks good to me overall, it should help with the randconfig > warnings I've been seeing and makes the driver structured more logically. > > The one part I wonder about is whether the platform_driver portion > should also be split out into a separate module in the same way. > > Arnd >
I think it should, I'm just waiting until I can find some time to bring up regmap for 1wire, then I can really clean things up and move the platform stuff (which is really the 1wire interface) out more cleanly, all I'll need to do then is just pass a regmap handle to the core from the interface modules.
But that's all a project for another day :)
| |