lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 22/72] md/raid10: submit_bio_wait() returns 0 on success
    Date
    From: Jes Sorensen <Jes.Sorensen@redhat.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 681ab4696062f5aa939c9e04d058732306a97176 upstream.

    This was introduced with 9e882242c6193ae6f416f2d8d8db0d9126bd996b
    which changed the return value of submit_bio_wait() to return != 0 on
    error, but didn't update the caller accordingly.

    Fixes: 9e882242c6 ("block: Add submit_bio_wait(), remove from md")
    Reported-by: Bill Kuzeja <William.Kuzeja@stratus.com>
    Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
    Signed-off-by: NeilBrown <neilb@suse.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/md/raid10.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
    index d525d663bb22..98c856dd8ccc 100644
    --- a/drivers/md/raid10.c
    +++ b/drivers/md/raid10.c
    @@ -2618,7 +2618,7 @@ static int narrow_write_error(struct r10bio *r10_bio, int i)
    choose_data_offset(r10_bio, rdev) +
    (sector - r10_bio->sector));
    wbio->bi_bdev = rdev->bdev;
    - if (submit_bio_wait(WRITE, wbio) == 0)
    + if (submit_bio_wait(WRITE, wbio) < 0)
    /* Failure! */
    ok = rdev_set_badblocks(rdev, sector,
    sectors, 0)
    --
    2.6.3


    \
     
     \ /
      Last update: 2015-11-23 14:41    [W:3.226 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site