lkml.org 
[lkml]   [2015]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH V4 0/3] Input: goodix - add axis swapping and axis inversion support
Date
Hello,

this is v4 of my "Input: goodix - add axis swapping and axis inversion
support" patchset.

The goodix touchscreen driver has gained device-tree support in kernel
4.1, but doesn't currently support the touchscreen-swapped-x-y,
touchscreen-inverted-x and touchscreen-inverted-y properties.
On systems which combine a portrait-mode display with a landscape-mode
touchscreen, such as e.g. the MSI Primo 81 tablet, support for these
features is necessary to have the touchscreen and the display use the
same coordinate system.

With support for axis inversion, the "rotated_screen" flag in the
driver can also be removed, as "rotated_screen" is just a special case
of x/y axis inversion.

This patchset sits on top of the "[PATCH v11 0/8] Goodix touchscreen
enhancements" series by Irina Tirdea:
https://www.spinics.net/lists/linux-input/msg42146.html

The axis swapping has successfully been tested on an MSI Primo 81
tablet and on a Wexler TAB7200 tablet; the x/y inversion resp.
the rotated_screen functionality has successfully been tested on
a WinBook TW100.

Regards,
Karsten

Changelog:

v1: * Initial version (based von v6 of Irina Tirdea's "Goodix
touchscreen enhancements" series).
Reviewed-by: Bastien Nocera <hadess@hadess.net>

v2: * Rebase against v8 of Irina Tirdea's "Goodix touchscreen
enhancements" series.
* Fix a typo in the commit message.
* Add an update for the goodix dt bindings documentation
(patch No. 3).
* Reviews/Tests:
Patch 1+2: Tested-by: Bastien Nocera <hadess@hadess.net>
Acked-by: Bastien Nocera <hadess@hadess.net>
Patch 2+3: Reviewed-by: Irina Tirdea <irina.tirdea@intel.com>

v3: * Rebase against v9 of Irina Tirdea's "Goodix touchscreen
enhancements" series.
* Address the review comments for patch No. 1 by Irina Tirdea
(https://www.spinics.net/lists/linux-input/msg41536.html):
- Move reading the dt properties from goodix_ts_probe to
goodix_configure_dev to make them work properly in all
configurations (with and without gpio declarations).
- Use the new unified device properties API (device_property_*)
instead of the classic DT API (of_property_*). This
provides support for ACPI 5.1 DSD properties as well as
for device-tree properties.
* Reviews/Tests:
Tested-by: Irina Tirdea <irina.tirdea@intel.com> (with ACPI DSD properties)
Tested-by: Aleksei Mamlin <mamlinav@gmail.com> (with device-tree properties)

v4: * Rebase against v11 of Irina Tirdea's "Goodix touchscreen
enhancements" series (no functional changes).

Karsten Merker (3):
Input: goodix - add axis swapping and axis inversion support
Input: goodix - use "inverted_[xy]" flags instead of "rotated_screen"
Input: goodix - update dt bindings documentation (axis
swapping/inversion)

.../bindings/input/touchscreen/goodix.txt | 5 ++++
drivers/input/touchscreen/goodix.c | 31 ++++++++++++++++++----
2 files changed, 31 insertions(+), 5 deletions(-)

--
2.1.4


\
 
 \ /
  Last update: 2015-11-21 15:01    [W:2.106 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site