lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink
On Fri, Nov 20, 2015 at 05:05:37PM -0700, Azael Avalos wrote:
> Hi Darren,
>
> 2015-11-20 16:19 GMT-07:00 Darren Hart <dvhart@infradead.org>:
> > On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote:
> >> The driver uses genetlink to inform userspace of events generated by
> >> the system, but the data passed is always zero as there is no data to
> >> pass, except for the hotkey event.
> >>
> >> This patch propagates the hotkey value via genetlink so userspace can
> >> make use of it.
> >
> > Which keys were not working previously?
>
> It's not about the keys, but the "extra events" generated, I still do not
> know why Toshiba sent system events inside the hotkey event (maybe
> they ran out of numbers...).
>
> >
> > My concern is that we introduce new events that then get "double handled".
> >
>
> Well, the events are already being generated, but they are Toshiba specific
> events, the only thing here that changed is that now we pass the hotkey value
> to userspace, and as said, some of the system events that were not passed
> before and are not handled at all.
>
> A good example here are the 0x1ABE and 0x1ABF events, which fire (on
> certain laptops) when the HDD protection level changes and is disabled
> respectively.
>
> There a re a lot of unknown events that are being sent as hotkeys, but
> I still have to ideintify them :-(

Thanks for the context, queued to testing.

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-11-21 02:01    [W:0.063 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site