Messages in this thread | | | Subject | Re: [PATCH v2] pstore-ram: add Device Tree bindings | From | Greg Hackmann <> | Date | Fri, 20 Nov 2015 10:32:08 -0800 |
| |
On 11/17/2015 01:17 PM, Rob Herring wrote: >> +- record-size: maximum size in bytes of each dump done on oops/panic >> + (defaults to 0) > > Perhaps the default should be something useful.
It's kind of a weird default, but I don't have any ideas for a better one.
First, the size you want is really determined by the number of dumps you want to keep in your circular buffer. That's not something I want to guess at.
Second, at least IME, a lot of devices legitimately want this set to 0. They're pulling in ramoops for the persistent kernel and userspace logs.
>> +- unbuffered: if present, use uncached mappings to map the reserved region >> + (defaults to cached mappings) > > It defaults to write-combined or buffered which is not really cached.
Will fix.
| |