lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] pstore-ram: add Device Tree bindings
From
Date
On 11/17/2015 01:17 PM, Rob Herring wrote:
>> +- record-size: maximum size in bytes of each dump done on oops/panic
>> + (defaults to 0)
>
> Perhaps the default should be something useful.

It's kind of a weird default, but I don't have any ideas for a better one.

First, the size you want is really determined by the number of dumps you
want to keep in your circular buffer. That's not something I want to
guess at.

Second, at least IME, a lot of devices legitimately want this set to 0.
They're pulling in ramoops for the persistent kernel and userspace logs.

>> +- unbuffered: if present, use uncached mappings to map the reserved region
>> + (defaults to cached mappings)
>
> It defaults to write-combined or buffered which is not really cached.

Will fix.


\
 
 \ /
  Last update: 2015-11-20 19:41    [W:0.111 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site