lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [alsa-devel] [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a
From
Hi Raphael


On Fri, Nov 20, 2015 at 3:42 PM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Nov 20, 2015 at 11:09:16AM +0100, Raphael Poggi wrote:
>> From: Raphael Poggi <poggi.raph@gmail.com>
>>
>> Add a binding for specify channel selection.
>>
>> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
>> ---
>> Documentation/devicetree/bindings/sound/pcm1792a.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>

can you add me in the patch-set?

Michael

>> diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt
>> index 970ba1e..6e87a3a 100644
>> --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt
>> +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt
>> @@ -9,10 +9,15 @@ Required properties:
>> For required properties on SPI, please consult
>> Documentation/devicetree/bindings/spi/spi-bus.txt
>>
>> +Optional properties:
>> +- ti,side: specifie the channel side
>
> typo
>
>> + insertion, removal.
>
> why the line wrap?
>
> I don't understand what this property is/does. Both the name and
> description are a bit terse.
>
>> +
>> Examples:
>>
>> codec_spi: 1792a@0 {
>> compatible = "ti,pcm1792a";
>> spi-max-frequency = <600000>;
>> + ti,side = <left>
> ^
> missing ;
>
>> };
>>
>> --
>> 2.1.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



--
| Michael Nazzareno Trimarchi Amarula Solutions BV |
| COO - Founder Cruquiuskade 47 |
| +31(0)851119172 Amsterdam 1018 AM NL |
| [`as] http://www.amarulasolutions.com |


\
 
 \ /
  Last update: 2015-11-20 16:21    [W:0.067 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site