lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] GPU-DRM-IMX: Delete an unnecessary check before drm_fbdev_cma_restore_mode()
    From
    Date
    Am Sonntag, den 05.07.2015, 22:50 +0200 schrieb SF Markus Elfring:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 5 Jul 2015 22:45:23 +0200
    >
    > The drm_fbdev_cma_restore_mode() function tests whether its argument
    > is NULL and then returns immediately.
    > Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/gpu/drm/imx/imx-drm-core.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
    > index 74f505b..9172c0e 100644
    > --- a/drivers/gpu/drm/imx/imx-drm-core.c
    > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
    > @@ -63,8 +63,7 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
    > #if IS_ENABLED(CONFIG_DRM_IMX_FB_HELPER)
    > struct imx_drm_device *imxdrm = drm->dev_private;
    >
    > - if (imxdrm->fbhelper)
    > - drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
    > + drm_fbdev_cma_restore_mode(imxdrm->fbhelper);
    > #endif
    > }
    >

    Applied, sorry I missed this before.

    regards
    Philipp



    \
     
     \ /
      Last update: 2015-11-20 14:21    [W:4.020 / U:2.816 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site