lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] cpufreq, intel_pstate, fix limits->max_perf rounding error
    Date
    A rounding error was found in the calculation of limits->max_perf
    in intel_pstate_set_policy(), which is used to calculate the max and min
    pstate values in intel_pstate_get_min_max(). In that code,
    limits->max_perf is truncated to 2 hex digits such that, for example,
    0x169 was incorrectly calculated to 0x16 instead of 0x17. This resulted in
    the pstate being set one level too low. This patch rounds the value of
    limits->max_perf up instead of down so that the correct max pstate can
    be reached.

    Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
    Cc: Len Brown <len.brown@intel.com>
    Cc: Alexandra Yates <alexandra.yates@intel.com>
    Cc: Kristen Carlson Accardi <kristen@linux.intel.com>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Cc: linux-pm@vger.kernel.org
    Signed-off-by: Prarit Bhargava <prarit@redhat.com>
    ---
    drivers/cpufreq/intel_pstate.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
    index 6b63374..8b8e331 100644
    --- a/drivers/cpufreq/intel_pstate.c
    +++ b/drivers/cpufreq/intel_pstate.c
    @@ -1122,6 +1122,7 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
    limits->max_sysfs_pct);
    limits->max_perf_pct = max(limits->min_policy_pct,
    limits->max_perf_pct);
    + limits->max_perf = round_up(limits->max_perf, 8);

    /* Make sure min_perf_pct <= max_perf_pct */
    limits->min_perf_pct = min(limits->max_perf_pct, limits->min_perf_pct);
    --
    1.8.3.1


    \
     
     \ /
      Last update: 2015-11-20 14:01    [W:2.952 / U:1.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site