Messages in this thread | | | From | Brendan Gregg <> | Date | Mon, 2 Nov 2015 15:59:49 -0800 | Subject | Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled |
| |
On Thu, Oct 22, 2015 at 7:03 AM, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote: > Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu: >> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote: >> > Hi Ingo, >> > >> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote: >> >> >> >> * Namhyung Kim <namhyung@kernel.org> wrote: >> >> >> >>> The caller callchain order is useful with --children option since it can >> >>> show 'overview' style output, but other commands which don't use >> >>> --children feature like 'perf script' or even 'perf report/top' without >> >>> --children are better to keep caller order. >> > >> > Oops, there's a typo: s/caller order/callee order/ :) >> >> Thanks, I was wondering about that (and I've made that typo myself). >> Thanks for the patch! > > Brendan, can I take that as an Acked-by?
Belated, yes!
Brendan
| |