lkml.org 
[lkml]   [2015]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next] serial: etraxfs-uart: Fix crash
    Helo Niklas,

    On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote:
    > On 11/02/2015 08:37 AM, Uwe Kleine-König wrote:
    > >> The function call in the etraxfs-uart driver was not renamed,
    > >> possibly due to interference with commit 7b9c5162c182 ("serial:
    > >> etraxfs-uart: use mctrl_gpio helpers for handling modem signals").
    > > Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling
    > > is missing.
    >
    > The only drivers including serial_mctrl_gpio.h is atmel_serial.c,
    > clps711x.c, mxs-auart.c and etraxfs-uart.c
    >
    > etraxfs commit
    > 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals")
    > is heavily influenced by
    > 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals")
    >
    > a driver which also appears to lack mctrl irq setup/handling.
    >
    >
    > Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to
    > use the new mctrl_gpio_init? (which also sets up irqs)
    That is the plan. For drivers like mxs-auart (that do irq handling) this
    is just simplification. When the irq handling is missing converting to
    the new mctrl_gpio_init might introduce regressions because it does
    request_irq which might fail.

    > Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if
    > they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling,
    > if we migrate it to use the new mctrl_gpio_init, we will get this automatically?
    Right, if there are no gpios specified (new and old) mctrl_gpio is a
    nop.

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |


    \
     
     \ /
      Last update: 2015-11-02 22:41    [W:4.208 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site