lkml.org 
[lkml]   [2015]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v2 1/3] restartable sequences: user-space per-cpu critical sections
    From
    Date
    On Tue, 2015-10-27 at 16:56 -0700, Paul Turner wrote:

    > + *  flags is currently unused.
    > + */
    > +SYSCALL_DEFINE3(restartable_sequences,
    > +> > > int, flags, long, event_and_cpu, long, post_commit_instr_addr)

    > +{
    > + return rseq_configure_current((__user u64 *)event_and_cpu,
    > +       (__user void *)post_commit_instr_addr);

    It seems that, for forward compatibility and actually usefulness of the
    'flags' argument, you need to reject the syscall if it's passed non-
    zero right now. Otherwise applications can (inadvertedly) pass garbage
    and you'll not be able to use it in the future.

    johannes


    \
     
     \ /
      Last update: 2015-11-19 18:01    [W:5.419 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site