lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 5/5] Add ioctls to enable and disable local controls on an instrument
On Sun, Nov 15, 2015 at 10:10:35PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 15, 2015 at 8:40 PM, Dave Penkler <dpenkler@gmail.com> wrote:
> > These ioctls provide support for the USBTMC-USB488 control requests
> > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT
> >
> > +
> > + dev = &data->intf->dev;
>
> Could be assigned above.
>

ok

> > + wValue = (val) ? 1 : 0;
>
> Redundant parens.
>

ok

> > + rv = -EIO;
>
> Hmm??? Does usb_control_msg() return a proper error code? If it does,
> perhaps better to propagate it.
>

You are right.

> > + rv = -EIO;
> > + goto exit;
>
> > + } else {
>
> Redundant else.
>

OK

>
Thanks,
-Dave


\
 
 \ /
  Last update: 2015-11-18 09:41    [W:0.112 / U:0.976 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site