lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Anonymous inode cleanup?
From
I see reference taken for the path and module in anon_inode_getfile()

Don't I need to drop that, or would fput() do it for me?

path_put(&path);
module_put(fops->owner);

On Wed, Nov 18, 2015 at 1:06 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, Nov 18, 2015 at 12:28:38PM -0800, Rajat Jain wrote:
>
>> > _If_ you are returning them via a sucky API, the right sequence is
>> > reserve the descriptor(s)
>> > set the file(s) up
>> > fill whatever structure you'll be using to report descriptors to
>> > userland and copy it to userland memory
>>
>> If this step fails, what is the cleanup needed for "set the files up"
>> anon_inode_getfile() step? is it fput()?
>
> Yes.


\
 
 \ /
  Last update: 2015-11-18 22:21    [W:0.056 / U:0.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site