lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c
Hi Jitendra,

[auto build test ERROR on: linuxtv-media/master]
[also build test ERROR on: v4.4-rc1 next-20151118]

url: https://github.com/0day-ci/linux/commits/Jitendra-Kumar-Khasdev/staging-media-bcm2048-fix-brace-coding-style-issue-in-radio-bcm2048-c/20151118-235820
base: git://linuxtv.org/media_tree.git master
config: tile-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile

All errors (new ones prefixed by >>):

drivers/staging/media/bcm2048/radio-bcm2048.c:2051:1: error: expected identifier or '(' before 'static'
drivers/staging/media/bcm2048/radio-bcm2048.c:2052:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2053:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2054:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2056:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2057:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2058:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2059:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2060:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2061:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2062:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2063:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2064:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2066:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2067:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2068:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2069:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2070:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2071:1: error: expected identifier or '(' before ')' token
drivers/staging/media/bcm2048/radio-bcm2048.c:2083:1: error: expected identifier or '(' before 'static'
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_sysfs_unregister_properties':
drivers/staging/media/bcm2048/radio-bcm2048.c:2155:43: error: 'attrs' undeclared (first use in this function)
drivers/staging/media/bcm2048/radio-bcm2048.c:2155:43: note: each undeclared identifier is reported only once for each function it appears in
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_sysfs_register_properties':
drivers/staging/media/bcm2048/radio-bcm2048.c:2165:18: error: 'attrs' undeclared (first use in this function)
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2165:18: error: negative width in bit-field '<anonymous>'
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_probe':
drivers/staging/media/bcm2048/radio-bcm2048.c:2650:44: error: 'attrs' undeclared (first use in this function)
drivers/staging/media/bcm2048/radio-bcm2048.c:2650:44: error: negative width in bit-field '<anonymous>'
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_remove':
drivers/staging/media/bcm2048/radio-bcm2048.c:2671:45: error: 'attrs' undeclared (first use in this function)
drivers/staging/media/bcm2048/radio-bcm2048.c:2671:45: error: negative width in bit-field '<anonymous>'
drivers/staging/media/bcm2048/radio-bcm2048.c: At top level:
drivers/staging/media/bcm2048/radio-bcm2048.c:449:12: warning: 'bcm2048_get_power_state' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:506:12: warning: 'bcm2048_set_rds' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:530:12: warning: 'bcm2048_get_rds_pi' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:554:12: warning: 'bcm2048_set_fm_hi_lo_injection' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:634:12: warning: 'bcm2048_set_fm_af_frequency' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:768:12: warning: 'bcm2048_get_region' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:1037:12: warning: 'bcm2048_set_rds_b_block_mask' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:1072:12: warning: 'bcm2048_set_rds_b_block_match' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:1108:12: warning: 'bcm2048_set_rds_pi_mask' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:1143:12: warning: 'bcm2048_set_rds_pi_match' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:1178:12: warning: 'bcm2048_set_fm_rds_mask' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:1239:12: warning: 'bcm2048_set_fm_best_tune_mode' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2052:1: warning: 'bcm2048_mute_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2053:1: warning: 'bcm2048_audio_route_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2054:1: warning: 'bcm2048_dac_output_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2056:1: warning: 'bcm2048_fm_hi_lo_injection_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2057:1: warning: 'bcm2048_fm_frequency_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2058:1: warning: 'bcm2048_fm_af_frequency_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2059:1: warning: 'bcm2048_fm_deemphasis_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2060:1: warning: 'bcm2048_fm_rds_mask_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2061:1: warning: 'bcm2048_fm_best_tune_mode_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2062:1: warning: 'bcm2048_fm_search_rssi_threshold_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2063:1: warning: 'bcm2048_fm_search_mode_direction_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2064:1: warning: 'bcm2048_fm_search_tune_mode_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2066:1: warning: 'bcm2048_rds_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2067:1: warning: 'bcm2048_rds_b_block_mask_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2068:1: warning: 'bcm2048_rds_b_block_match_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2069:1: warning: 'bcm2048_rds_pi_mask_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2070:1: warning: 'bcm2048_rds_pi_match_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2071:1: warning: 'bcm2048_rds_wline_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2073:1: warning: 'bcm2048_rds_rt_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2074:1: warning: 'bcm2048_rds_ps_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2076:1: warning: 'bcm2048_fm_rds_flags_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2077:1: warning: 'bcm2048_rds_data_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2079:1: warning: 'bcm2048_region_bottom_frequency_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2080:1: warning: 'bcm2048_region_top_frequency_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2081:1: warning: 'bcm2048_fm_carrier_error_read' defined but not used [-Wunused-function]
drivers/staging/media/bcm2048/radio-bcm2048.c:2082:1: warning: 'bcm2048_fm_rssi_read' defined but not used [-Wunused-function]

vim +2165 drivers/staging/media/bcm2048/radio-bcm2048.c

899127b6 Hans Verkuil 2013-11-04 2063 DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2064 DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
899127b6 Hans Verkuil 2013-11-04 2065
899127b6 Hans Verkuil 2013-11-04 2066 DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2067 DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2068 DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 @2069 DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2070 DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2071 DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2072 property_read(rds_pi, unsigned int, "%x")
899127b6 Hans Verkuil 2013-11-04 2073 property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
899127b6 Hans Verkuil 2013-11-04 2074 property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
899127b6 Hans Verkuil 2013-11-04 2075
899127b6 Hans Verkuil 2013-11-04 2076 property_read(fm_rds_flags, unsigned int, "%u")
899127b6 Hans Verkuil 2013-11-04 2077 property_str_read(rds_data, BCM2048_MAX_RDS_RADIO_TEXT*5)
899127b6 Hans Verkuil 2013-11-04 2078
899127b6 Hans Verkuil 2013-11-04 2079 property_read(region_bottom_frequency, unsigned int, "%u")
899127b6 Hans Verkuil 2013-11-04 2080 property_read(region_top_frequency, unsigned int, "%u")
899127b6 Hans Verkuil 2013-11-04 2081 property_signed_read(fm_carrier_error, int, "%d")
899127b6 Hans Verkuil 2013-11-04 2082 property_signed_read(fm_rssi, int, "%d")
899127b6 Hans Verkuil 2013-11-04 2083 DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
899127b6 Hans Verkuil 2013-11-04 2084
899127b6 Hans Verkuil 2013-11-04 2085 static struct device_attribute attrs[] = {
899127b6 Hans Verkuil 2013-11-04 2086 __ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
899127b6 Hans Verkuil 2013-11-04 2087 bcm2048_power_state_write),
899127b6 Hans Verkuil 2013-11-04 2088 __ATTR(mute, S_IRUGO | S_IWUSR, bcm2048_mute_read,
899127b6 Hans Verkuil 2013-11-04 2089 bcm2048_mute_write),
899127b6 Hans Verkuil 2013-11-04 2090 __ATTR(audio_route, S_IRUGO | S_IWUSR, bcm2048_audio_route_read,
899127b6 Hans Verkuil 2013-11-04 2091 bcm2048_audio_route_write),
899127b6 Hans Verkuil 2013-11-04 2092 __ATTR(dac_output, S_IRUGO | S_IWUSR, bcm2048_dac_output_read,
899127b6 Hans Verkuil 2013-11-04 2093 bcm2048_dac_output_write),
899127b6 Hans Verkuil 2013-11-04 2094 __ATTR(fm_hi_lo_injection, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2095 bcm2048_fm_hi_lo_injection_read,
899127b6 Hans Verkuil 2013-11-04 2096 bcm2048_fm_hi_lo_injection_write),
899127b6 Hans Verkuil 2013-11-04 2097 __ATTR(fm_frequency, S_IRUGO | S_IWUSR, bcm2048_fm_frequency_read,
899127b6 Hans Verkuil 2013-11-04 2098 bcm2048_fm_frequency_write),
899127b6 Hans Verkuil 2013-11-04 2099 __ATTR(fm_af_frequency, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2100 bcm2048_fm_af_frequency_read,
899127b6 Hans Verkuil 2013-11-04 2101 bcm2048_fm_af_frequency_write),
899127b6 Hans Verkuil 2013-11-04 2102 __ATTR(fm_deemphasis, S_IRUGO | S_IWUSR, bcm2048_fm_deemphasis_read,
899127b6 Hans Verkuil 2013-11-04 2103 bcm2048_fm_deemphasis_write),
899127b6 Hans Verkuil 2013-11-04 2104 __ATTR(fm_rds_mask, S_IRUGO | S_IWUSR, bcm2048_fm_rds_mask_read,
899127b6 Hans Verkuil 2013-11-04 2105 bcm2048_fm_rds_mask_write),
899127b6 Hans Verkuil 2013-11-04 2106 __ATTR(fm_best_tune_mode, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2107 bcm2048_fm_best_tune_mode_read,
899127b6 Hans Verkuil 2013-11-04 2108 bcm2048_fm_best_tune_mode_write),
899127b6 Hans Verkuil 2013-11-04 2109 __ATTR(fm_search_rssi_threshold, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2110 bcm2048_fm_search_rssi_threshold_read,
899127b6 Hans Verkuil 2013-11-04 2111 bcm2048_fm_search_rssi_threshold_write),
899127b6 Hans Verkuil 2013-11-04 2112 __ATTR(fm_search_mode_direction, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2113 bcm2048_fm_search_mode_direction_read,
899127b6 Hans Verkuil 2013-11-04 2114 bcm2048_fm_search_mode_direction_write),
899127b6 Hans Verkuil 2013-11-04 2115 __ATTR(fm_search_tune_mode, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2116 bcm2048_fm_search_tune_mode_read,
899127b6 Hans Verkuil 2013-11-04 2117 bcm2048_fm_search_tune_mode_write),
899127b6 Hans Verkuil 2013-11-04 2118 __ATTR(rds, S_IRUGO | S_IWUSR, bcm2048_rds_read,
899127b6 Hans Verkuil 2013-11-04 2119 bcm2048_rds_write),
899127b6 Hans Verkuil 2013-11-04 2120 __ATTR(rds_b_block_mask, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2121 bcm2048_rds_b_block_mask_read,
899127b6 Hans Verkuil 2013-11-04 2122 bcm2048_rds_b_block_mask_write),
899127b6 Hans Verkuil 2013-11-04 2123 __ATTR(rds_b_block_match, S_IRUGO | S_IWUSR,
899127b6 Hans Verkuil 2013-11-04 2124 bcm2048_rds_b_block_match_read,
899127b6 Hans Verkuil 2013-11-04 2125 bcm2048_rds_b_block_match_write),
899127b6 Hans Verkuil 2013-11-04 2126 __ATTR(rds_pi_mask, S_IRUGO | S_IWUSR, bcm2048_rds_pi_mask_read,
899127b6 Hans Verkuil 2013-11-04 2127 bcm2048_rds_pi_mask_write),
899127b6 Hans Verkuil 2013-11-04 2128 __ATTR(rds_pi_match, S_IRUGO | S_IWUSR, bcm2048_rds_pi_match_read,
899127b6 Hans Verkuil 2013-11-04 2129 bcm2048_rds_pi_match_write),
899127b6 Hans Verkuil 2013-11-04 2130 __ATTR(rds_wline, S_IRUGO | S_IWUSR, bcm2048_rds_wline_read,
899127b6 Hans Verkuil 2013-11-04 2131 bcm2048_rds_wline_write),
899127b6 Hans Verkuil 2013-11-04 2132 __ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2133 __ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2134 __ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2135 __ATTR(fm_rds_flags, S_IRUGO, bcm2048_fm_rds_flags_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2136 __ATTR(region_bottom_frequency, S_IRUGO,
899127b6 Hans Verkuil 2013-11-04 2137 bcm2048_region_bottom_frequency_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2138 __ATTR(region_top_frequency, S_IRUGO,
899127b6 Hans Verkuil 2013-11-04 2139 bcm2048_region_top_frequency_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2140 __ATTR(fm_carrier_error, S_IRUGO,
899127b6 Hans Verkuil 2013-11-04 2141 bcm2048_fm_carrier_error_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2142 __ATTR(fm_rssi, S_IRUGO,
899127b6 Hans Verkuil 2013-11-04 2143 bcm2048_fm_rssi_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2144 __ATTR(region, S_IRUGO | S_IWUSR, bcm2048_region_read,
899127b6 Hans Verkuil 2013-11-04 2145 bcm2048_region_write),
899127b6 Hans Verkuil 2013-11-04 2146 __ATTR(rds_data, S_IRUGO, bcm2048_rds_data_read, NULL),
899127b6 Hans Verkuil 2013-11-04 2147 };
899127b6 Hans Verkuil 2013-11-04 2148
899127b6 Hans Verkuil 2013-11-04 2149 static int bcm2048_sysfs_unregister_properties(struct bcm2048_device *bdev,
899127b6 Hans Verkuil 2013-11-04 2150 int size)
899127b6 Hans Verkuil 2013-11-04 2151 {
899127b6 Hans Verkuil 2013-11-04 2152 int i;
899127b6 Hans Verkuil 2013-11-04 2153
899127b6 Hans Verkuil 2013-11-04 2154 for (i = 0; i < size; i++)
899127b6 Hans Verkuil 2013-11-04 2155 device_remove_file(&bdev->client->dev, &attrs[i]);
899127b6 Hans Verkuil 2013-11-04 2156
899127b6 Hans Verkuil 2013-11-04 2157 return 0;
899127b6 Hans Verkuil 2013-11-04 2158 }
899127b6 Hans Verkuil 2013-11-04 2159
899127b6 Hans Verkuil 2013-11-04 2160 static int bcm2048_sysfs_register_properties(struct bcm2048_device *bdev)
899127b6 Hans Verkuil 2013-11-04 2161 {
899127b6 Hans Verkuil 2013-11-04 2162 int err = 0;
899127b6 Hans Verkuil 2013-11-04 2163 int i;
899127b6 Hans Verkuil 2013-11-04 2164
899127b6 Hans Verkuil 2013-11-04 @2165 for (i = 0; i < ARRAY_SIZE(attrs); i++) {
899127b6 Hans Verkuil 2013-11-04 2166 if (device_create_file(&bdev->client->dev, &attrs[i]) != 0) {
899127b6 Hans Verkuil 2013-11-04 2167 dev_err(&bdev->client->dev,
899127b6 Hans Verkuil 2013-11-04 2168 "could not register sysfs entry\n");

:::::: The code at line 2165 was first introduced by commit
:::::: 899127b67df098e6d878f27be05dc91401cc6685 [media] This adds support for the BCM2048 radio module found in Nokia N900

:::::: TO: Hans Verkuil <hans.verkuil@cisco.com>
:::::: CC: Mauro Carvalho Chehab <m.chehab@samsung.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2015-11-18 17:21    [W:0.095 / U:0.916 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site