lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] KVM-async_pf: Delete an unnecessary check before the function call "kmem_cache_destroy"
    From
    Date


    On 15/11/2015 10:45, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 15 Nov 2015 10:40:36 +0100
    >
    > The kmem_cache_destroy() function tests whether its argument is NULL
    > and then returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > virt/kvm/async_pf.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c
    > index 77d42be..3531599 100644
    > --- a/virt/kvm/async_pf.c
    > +++ b/virt/kvm/async_pf.c
    > @@ -57,8 +57,7 @@ int kvm_async_pf_init(void)
    >
    > void kvm_async_pf_deinit(void)
    > {
    > - if (async_pf_cache)
    > - kmem_cache_destroy(async_pf_cache);
    > + kmem_cache_destroy(async_pf_cache);
    > async_pf_cache = NULL;
    > }
    >
    >

    Applied to kvm/queue, thanks.

    Paolo


    \
     
     \ /
      Last update: 2015-11-18 12:21    [W:4.024 / U:3.896 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site