lkml.org 
[lkml]   [2015]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] dl2k: Implement suspend
Date
On Tuesday 17 November 2015, Francois Romieu wrote:
> Ondrej Zary <linux@rainbow-software.org> :
> [...]
>
> > diff --git a/drivers/net/ethernet/dlink/dl2k.c
> > b/drivers/net/ethernet/dlink/dl2k.c index 9e9baa0..b53dfa7 100644
> > --- a/drivers/net/ethernet/dlink/dl2k.c
> > +++ b/drivers/net/ethernet/dlink/dl2k.c
> > @@ -1824,11 +1824,57 @@ rio_remove1 (struct pci_dev *pdev)
> > }
> > }
> >
> > +#ifdef CONFIG_PM
> > +static int rio_suspend(struct pci_dev *pdev, pm_message_t state)
> > +{
> > + struct net_device *dev = pci_get_drvdata(pdev);
> > + struct netdev_private *np = netdev_priv(dev);
> > +
> > + pci_save_state(pdev);
>
> Cargo-cultism ?
>
> > +
> > + if (netif_running(dev)) {
> > + netif_device_detach(dev);
> > + del_timer_sync(&np->timer);
> > + rio_hw_stop(dev);
> > + free_list(dev);
>
> If free_list is used here, so must alloc_list be in resume, whence
> an extra failure opportunity.
>
> You may not need to free both Tx and Rx here.

I'll better drop the free_list/alloc_list from suspend/resume (as you
suggested before).

> [...]
>
> > static struct pci_driver rio_driver = {
> > .name = "dl2k",
> > .id_table = rio_pci_tbl,
> > .probe = rio_probe1,
> > .remove = rio_remove1,
> > +#ifdef CONFIG_PM
> > + .suspend = rio_suspend,
> > + .resume = rio_resume,
> > +#endif /* CONFIG_PM */
>
> It looks a bit old school.
>
> See Documentation/power/pci.txt and drivers/net/ethernet/via/via-rhine.c
> for an instance of SIMPLE_DEV_PM_OPS.
>
> At some point you'll probably support runtime power management though.

Thanks for suggestion, I've been looking at the wrong drivers as none of them
used dev_pm_ops.

--
Ondrej Zary


\
 
 \ /
  Last update: 2015-11-18 10:41    [W:0.047 / U:6.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site