Messages in this thread | | | Date | Wed, 18 Nov 2015 11:21:01 +1100 (AEDT) | From | James Morris <> | Subject | Re: [PATCH 2/2] keys, trusted: seal with a policy |
| |
On Tue, 17 Nov 2015, Jarkko Sakkinen wrote:
> } > break; > + case Opt_policydigest: > + if (!tpm2 || > + strlen(args[0].from) != (2 * opt->digest_len)) > + return -EINVAL; > + kfree(opt->policydigest); > + opt->policydigest = kzalloc(opt->digest_len, > + GFP_KERNEL);
Is it correct to kfree opt->policydigest here before allocating it?
> + if (!opt->policydigest) > + return -ENOMEM; > + res = hex2bin(opt->policydigest, args[0].from, > + opt->digest_len); > + if (res < 0) > + return -EINVAL;
Do you need to kfree it here on error?
-- James Morris <jmorris@namei.org>
| |