Messages in this thread | | | Date | Tue, 17 Nov 2015 23:48:55 +0100 (CET) | From | Jan Engelhardt <> | Subject | Re: [PATCH 2/5] kernfs: implement kernfs_walk_and_get() |
| |
On Tuesday 2015-11-17 22:20, David Miller wrote: >> + static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ >> + int len = strlen(path); > ... >> + if (len >= PATH_MAX) >> + return NULL; >> + >> + memcpy(path_buf, path, len + 1); > > static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ > int len = strlcpy(path_buf, path, PATH_MAX); > ... > if (len >= PATH_MAX) > return NULL;
if (len < 0 || len >= PATH_MAX)
strlcpy returns a size_t, which, when coerced into an int, could lead to negative numbers. In that sense, "size_t len" probably seems like an even better bet yet.
| |