lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] kernfs: implement kernfs_walk_and_get()

On Tuesday 2015-11-17 22:20, David Miller wrote:
>> + static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */
>> + int len = strlen(path);
> ...
>> + if (len >= PATH_MAX)
>> + return NULL;
>> +
>> + memcpy(path_buf, path, len + 1);
>
> static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */
> int len = strlcpy(path_buf, path, PATH_MAX);
> ...
> if (len >= PATH_MAX)
> return NULL;

if (len < 0 || len >= PATH_MAX)

strlcpy returns a size_t, which, when coerced into an int, could lead to
negative numbers. In that sense, "size_t len" probably seems like an even
better bet yet.


\
 
 \ /
  Last update: 2015-11-18 00:21    [W:0.089 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site